Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual num pad is missing cancel button #9302

Open
1 task done
Branikolog opened this issue Nov 27, 2024 · 2 comments
Open
1 task done

Virtual num pad is missing cancel button #9302

Branikolog opened this issue Nov 27, 2024 · 2 comments
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Milestone

Comments

@Branikolog
Copy link
Collaborator

Preliminary checks

Describe the problem requiring a solution

It seems like sometimes player changes his mind and wants just to skip number selection.

2024-11-27.11-44-25.mp4

Without cancel button and small available range of numbers it could be quite annoying to get back to the previous dialog.

Describe the possible solution

I suggest adding "Cancel" button to this dialog for easier returning to the previous window.

Additional info

No response

@Branikolog Branikolog added improvement New feature, request or improvement ui UI/GUI related stuff labels Nov 27, 2024
@Branikolog Branikolog added this to the 1.1.7 milestone Nov 27, 2024
@oleg-derevenetz
Copy link
Collaborator

This virtual numpad is just a variant of the virtual keyboard. Have you ever seen the "Cancel" button anywhere on devices with a virtual keyboard (Android, iOS)? :)

@Branikolog
Copy link
Collaborator Author

Hi, @oleg-derevenetz !

Have you ever seen the "Cancel" button anywhere on devices with a virtual keyboard (Android, iOS)? :)

Well, there's always a device default cancel button in the bottom of the screen, that anyone can press to cancel keyboard. :)
I understand your point, but in a current implementation it is sometimes too difficult to return back to the previous dialog. If we're working with a tiny creature number (like - 1-3 monsters), we need to click precisely within these three buttons. If a player either had forgotten the initial number of available monsters, or trying to buy monsters having insufficient resources, he comes up with warning message, that he has to select specific numbers. He has to read the whole message to find out the range available or select numbers randomly trying to guess the number, that game will accept. By that time he obviously can decide not to select any number and just go back focusing on some other actions.
So there is no critical issue here, other than the current behavior is just a little unfriendly.

Virtual numpad could be cancelled with a click on the area outside of the window, but it lies out of the overall UI design and simply was not implemented before (requiring new logic for implementing such behaviour). So in my opinion having "cancel" button is a nice solution to return back without thinking what number I have to click to close this numpad keyboard.

If you think this enhancement is questionable, you are free to convert the issue to discussion. 🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

No branches or pull requests

2 participants