Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHILLED code needs to be cleaned up #22

Open
measrainsey opened this issue Aug 1, 2024 · 1 comment
Open

CHILLED code needs to be cleaned up #22

measrainsey opened this issue Aug 1, 2024 · 1 comment
Assignees
Labels
chilled PRs and issues related to the CHILLED model enhancement New feature or request

Comments

@measrainsey
Copy link
Contributor

measrainsey commented Aug 1, 2024

As pointed out by @glatterf42 in #18 (review), the CHILLED code would benefit from the following upgrades:

Code could still be cleaned up (e.g. by adding mypy and ruff like we have them in message_ix and addressing linting/formatting errors or by cleaning up comments and type: ignore statements), but this could also happen in a later PR. If saved for later, please open an issue to not forget about this.

This issue is meant to track this work that needs to be done.

@measrainsey measrainsey self-assigned this Aug 1, 2024
@measrainsey measrainsey added enhancement New feature or request chilled PRs and issues related to the CHILLED model labels Aug 1, 2024
@measrainsey
Copy link
Contributor Author

Making a note that I should really reconfigure the message_ix_buildings.chilled.core.climate.create_climate_variables_maps function because right now the complexity of that function is 39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chilled PRs and issues related to the CHILLED model enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant