-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated signature of creating data frames in tutorials with make_df
#502
Comments
make_df
I think that the routine overall is ok and it will help to clean up the tutorials..BUT... |
This can be handled in multiple ways:
These are in order of preference, i.e. (3) is the least preferable. Tutorials are the slowest part of the test suite and are less easy to access than (1) and (2) directly in the docs. Per (2), the docs can be just as narrative or descriptive as a tutorial.
This could be handled with the current issue, but could also be dealt with separately. |
Using the new signature to create the data frame with the
make_df()
function in the tutorials might increase the understanding of them.As I understood correctly the old signature needs the following code to create the data frame (e.g. data frame from the
westeros_emissions_bounds
tutorial):Which can also be achieved by the new signature without the need to build a dictionary to append:
Any thoughts @OFR-IIASA and @khaeru?
I'm happy to change it, if wanted.
The text was updated successfully, but these errors were encountered: