Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign AccessControlSettingOperation using ContextExclusionFilterFactory #290

Open
ldko opened this issue Sep 29, 2015 · 0 comments
Open

Comments

@ldko
Copy link
Member

ldko commented Sep 29, 2015

Currently AccessControlSettingOperation seems awkward as it implements BooleanOperator with its isTrue() method directly setting the exclusionFilter on the WaybackRequest instance before always returning true. To be consistent with development moving toward creating ExclusionFilters by implementing ContextExclusionFilterFactory, AccessControlSettingOperation should be redesigned for OpenWayback 3.0. This issue stems from the discussion on issue #259 where Kenji recommended:

"Toward 3.0, I'd propose redesigning AccessControlSettingOperation as ContextExclusionFilterFactory and have it set up through AccessPoint.exclusionFactory. It'll require adding WaybackRequest (or narrower interface) to its getExclusionFilter method."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants