You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently AccessControlSettingOperation seems awkward as it implements BooleanOperator with its isTrue() method directly setting the exclusionFilter on the WaybackRequest instance before always returning true. To be consistent with development moving toward creating ExclusionFilters by implementing ContextExclusionFilterFactory, AccessControlSettingOperation should be redesigned for OpenWayback 3.0. This issue stems from the discussion on issue #259 where Kenji recommended:
"Toward 3.0, I'd propose redesigning AccessControlSettingOperation as ContextExclusionFilterFactory and have it set up through AccessPoint.exclusionFactory. It'll require adding WaybackRequest (or narrower interface) to its getExclusionFilter method."
The text was updated successfully, but these errors were encountered:
Currently
AccessControlSettingOperation
seems awkward as it implementsBooleanOperator
with itsisTrue(
) method directly setting theexclusionFilter
on theWaybackRequest
instance before always returning true. To be consistent with development moving toward creating ExclusionFilters by implementingContextExclusionFilterFactory
,AccessControlSettingOperation
should be redesigned for OpenWayback 3.0. This issue stems from the discussion on issue #259 where Kenji recommended:"Toward 3.0, I'd propose redesigning
AccessControlSettingOperation
asContextExclusionFilterFactory
and have it set up throughAccessPoint.exclusionFactory
. It'll require addingWaybackRequest
(or narrower interface) to itsgetExclusionFilter
method."The text was updated successfully, but these errors were encountered: