Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish crate for serde_json fork #76

Closed
opsengine opened this issue Apr 21, 2020 · 4 comments
Closed

Publish crate for serde_json fork #76

opsengine opened this issue Apr 21, 2020 · 4 comments

Comments

@opsengine
Copy link

The code depends on a fork of serde_json. There is only one commit (9e9a959fce6075e90526bc3af4bde509a9af17dd) but it seems pretty important.
Would it be possible to publish the fork on crates.io under a new name i.e. serde_orjson or something? It would make it much easier to work with cargo vendor.
Thanks!
@ijl
Copy link
Owner

ijl commented Apr 24, 2020

Do you clone the repo or download the source distribution from PyPI? I'd prefer to not publish the fork because it's not generally usable. It could be vendored into this repository or maturin could be modified to vendor everything.

@opsengine
Copy link
Author

We clone the repo. That's ok though, we did a workaround so I'm closing the issue.

@ijl
Copy link
Owner

ijl commented Apr 28, 2020

That's good. It needs to be solved in general still, and will be vendored into this repository and published after PyO3/maturin#296.

@ijl ijl reopened this Apr 28, 2020
@ijl
Copy link
Owner

ijl commented Apr 30, 2020

https://github.com/ijl/orjson/releases/tag/2.6.8

@ijl ijl closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@opsengine @ijl