Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of access functions in etsi_its_msgs_utils #50

Open
TiagoRG opened this issue Dec 4, 2024 · 1 comment
Open

Creation of access functions in etsi_its_msgs_utils #50

TiagoRG opened this issue Dec 4, 2024 · 1 comment

Comments

@TiagoRG
Copy link

TiagoRG commented Dec 4, 2024

Hey

I've been working on AutowareV2X, with Instituto de Telecomunicações, and recently we've integrated your work into it for the ROS messages. So far we've integrated the ROS messages for CAMs and our next goal would be to use the access functions in etsi_its_msgs_utils instead of defining the values manually as well as CPMs, etc.

We've realized not all parameters have their respective access functions implemented and we'd like to contribute to them, however I can't seem to understand how these functions are compiled/generated and so I'd like to ask if you could give some insights on how to do so.

Thank you.

@lreiher
Copy link
Member

lreiher commented Dec 6, 2024

Hi Tiago,

cool to hear that you are working on an Autoware integration! We wanted to also have a look at the current state of AutowareV2X soon because I believe we have some ideas on how to improve the overall integration.

Regarding your question: all access functions are manually implemented in the etsi_its_msgs_utils package, e.g., in cam_setters_common.h for setters common to CAM and CAM TS/v2.

We decided to manually implement only those functions that seem useful for particular implementations, e.g., accessing relevant properties for visualization in Rviz. If you were to auto-generate getters/setters for all attributes, you would end up with super long functions names not giving you any real benefit than just stepping through the message hierarchy via dot-notation.

That being said, you are welcome to add additional helpful getters/settters to the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants