Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check coding standards in diff view #190

Open
str opened this issue Mar 16, 2021 · 0 comments
Open

Do not check coding standards in diff view #190

str opened this issue Mar 16, 2021 · 0 comments

Comments

@str
Copy link

str commented Mar 16, 2021

When comparing changes before commiting them, the PHPCS shows a lot of errors.

The errors on the "before" side, do not matter because you can't do anything for what was before. The errors on the "changes" side, do not matter neither because you are not editing the file, you are just comparing changes. If you want to see if your changes break any CS rule, go and edit it.

Also, the CS rules defined in the phpcs.xml are ignored in this view, so the broken rules shown in this view are wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant