Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admm headers have a dependency issue #9

Open
smu160 opened this issue Jun 17, 2020 · 0 comments
Open

admm headers have a dependency issue #9

smu160 opened this issue Jun 17, 2020 · 0 comments
Labels

Comments

@smu160
Copy link
Collaborator

smu160 commented Jun 17, 2020

In general, headers should not be dependent upon other headers being included first. In admm.cpp, rearranging the order of those three headers causes compile time errors. Specifically, including admm.h (which is the desired order) prior to line_search.h and glmgen.h causes issues.

#include "line_search.h"
#include "glmgen.h"
#include "admm.h"

Attempted to fix by placing #include "glmgen.h" in admm.h, but this causes issues when building the trefide python package.

See:

#include "line_search.h"

@smu160 smu160 added the bug label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant