Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARVM destroy doesn't convert errors to deserialization errors #83

Open
chrisandreae opened this issue Dec 26, 2017 · 1 comment
Open

Comments

@chrisandreae
Copy link
Member

https://github.com/iknow/iknow_view_models/blob/master/lib/view_model/active_record.rb#L307

https://github.com/iknow/iknow_view_models/blob/master/lib/view_model/active_record/update_context.rb#L162

So database errors such as foreign key violations will bubble out unwrapped. I think we don't want this.

@thefloweringash
Copy link
Contributor

Probably needs an adaptation of this

rescue ::ActiveRecord::StatementInvalid, ::ActiveRecord::InvalidForeignKey, ::ActiveRecord::RecordNotSaved => ex
raise ViewModel::DeserializationError::DatabaseConstraint.new(ex.message, blame_reference)
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants