Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surprising Time Spent on Running msvc-dev-cmd@v1 on windows-latest #12

Closed
davecom opened this issue Sep 27, 2020 · 6 comments
Closed

Surprising Time Spent on Running msvc-dev-cmd@v1 on windows-latest #12

davecom opened this issue Sep 27, 2020 · 6 comments

Comments

@davecom
Copy link

davecom commented Sep 27, 2020

I'm suddenly seeing repositories take over 4 minutes on running msvc-dev-cmd@v1, while just a couple days ago they were taking less than a minute. What variables could be causing the increased time? Is there something I can tweak? Does it have to do with changes to windows-latest? Thanks in advance for any insight.

Below is our yml file and the step that is becoming perversely long is "Setup Developer Command Prompt"

name: Build and Test

on:
  push

jobs:

  build-and-test-windows:
    name: Build and Test on Windows
    runs-on: windows-latest
    timeout-minutes: 5

    steps:
      - name: Setup Developer Command Prompt
        uses: ilammy/msvc-dev-cmd@v1
      - name: Check Out Source Code
        uses: actions/checkout@v2
      - name: nmake Build
        run: nmake
      - name: Run Executable
        run: .\assignment4.exe

  build-and-test-linux:
    name: Build and Test on Linux
    runs-on: ubuntu-latest
    timeout-minutes: 5

    steps:
      - name: Check Out Source Code
        uses: actions/checkout@v2
      - name: GNU make Build
        run: make
      - name: Run Executable
        run: ./assignment4
@ilammy
Copy link
Owner

ilammy commented Sep 27, 2020

Hm... That's most likely due to v1 being updated to recently released v1.4.0. I am sorry, I did not notice the build time increase 😞 Indeed, it seems to take way more time than necessary, it's not clear why.

As a mitigation, I have reverted the v1 tag back to more stable v1.3.0 which it still fast. (That is, ilammy/msvc-dev-cmd@v1 should be fast now.) The v1.4.0 is also demoted to pre-release state, until the next version does something about the execution speed.

@davecom
Copy link
Author

davecom commented Sep 27, 2020

Thank you @ilammy. Appreciate the work you have done on msvc-dev-cmd and the quick response.

@FranciscoPombal
Copy link

I can reproduce this issue. v1.3.0 used to take less than 10 seconds to complete (see any Windows job here: https://github.com/qbittorrent/qBittorrent/actions, for an example of this), while v1.4.0 consistently takes an additional 4 minutes. So for now v1.3.0 is definitely the one to use.

@ilammy
Copy link
Owner

ilammy commented Oct 3, 2020

@davecom, @FranciscoPombal, I've just published v1.4.1 which should fix this issue. Could you please give it a try?
If that works for you, I'll bump v1 to that version.

@FranciscoPombal
Copy link

@ilammy Thanks, that fixed it!

@ilammy
Copy link
Owner

ilammy commented Oct 7, 2020

Alrighty. I've bumped v1 to the latest release. It seems that's it 🎉

@ilammy ilammy closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants