Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add more subscription snippets #16

Closed
TomerFi opened this issue Mar 30, 2022 · 2 comments · Fixed by #30
Closed

[feat] add more subscription snippets #16

TomerFi opened this issue Mar 30, 2022 · 2 comments · Fixed by #30
Assignees
@vbelouso
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TomerFi
Copy link
Collaborator

TomerFi commented Mar 30, 2022

The current subscription snippet is of a git-typed application, adding two more snippets for helm-typed and object-typed applications, should be a good idea and quite easy to accomplish.
@TomerFi TomerFi added good first issue Good for newcomers enhancement New feature or request labels Apr 3, 2022
@TomerFi
Copy link
Collaborator Author

TomerFi commented Apr 4, 2022

To be more specific, in a similar manner to the subscription-git snippet,
we need to add snippets for other application types besides git,
such as helmrepo, objectbucket, and namespace.

@vbelouso
Copy link
Collaborator

vbelouso commented Apr 4, 2022

@ilan-pinto please assign this issue to me

@vbelouso vbelouso mentioned this issue Apr 4, 2022
Merged
@vbelouso vbelouso self-assigned this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbelouso vbelouso

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add helmrepo and object storage snippets vbelouso/ocm-vscode-extension
2 participants
@TomerFi @vbelouso