New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass zip_safe=False to setup() #151

Merged

ilanschnell merged 1 commit into ilanschnell:master from bcb:add-zip_safe

Oct 26, 2021

Contributor

bcb commented Oct 26, 2021

I noticed py.typed is not being installed with this library, which makes mypy complain that the library is not typed.

The file is included in package_data, but you also need to add zip_safe=False in order for this to work - see mypy docs.


Pass zip_safe=False to setup()

061ce0f

Owner

ilanschnell commented Oct 26, 2021

Thanks for the PR! Good catch. I thought that since the package contains C extensions, it wouldn't be zip-safe anyway, but it's better to explicit.

ilanschnell merged commit d05dd66 into ilanschnell:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment