Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaking As Selection icons with spaces are re-encoding % character #212

Closed
shinkei13 opened this issue Aug 26, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@shinkei13
Copy link

Describe the bug
When I upload Tokens into ForgeVTT and they have spaces in the filename, they are incorrectly being represented in the Speaking As dropdown as broken images.

What steps did you take before experiencing the problem?
Steps to reproduce the behavior:

  1. Go to Chat Sidebar
  2. Right Click on 'You: Gamemaster'
  3. Scroll down to any Owned Token with a space in the filename
  4. See error

What did you expect to happen?
The Token URL should not be encoded when a URL is already present, to avoid encoding it twice.

What happened instead?
Spaces in the filename are being modified to "%2520" instead of "%20". The "%" in "%20" is being re-encoded as "%25"

Screenshots
Screenshot 2024-08-26 at 2 46 18 PM
Screenshot 2024-08-26 at 2 46 53 PM
Screenshot 2024-08-26 at 2 47 21 PM

Foundry Versions

  • Version of this module: 3.0.0
  • Foundry Version: v12 Stable 331
  • System Name and Version: D&D 5e 3.3.1
  • Browser Name and Version: Google Chrome 128.0.6613.84

What other modules did you have active when experiencing this issue (include both names and versions)?
The Forge 1.14.9

@shinkei13 shinkei13 added the bug Something isn't working label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants
@illandril @shinkei13 and others