Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work if the macro's format isn't perfect #4

Closed
Jonwh25 opened this issue Aug 31, 2020 · 1 comment
Closed

Doesn't work if the macro's format isn't perfect #4

Jonwh25 opened this issue Aug 31, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Jonwh25
Copy link

Jonwh25 commented Aug 31, 2020

Seems to require you to have Minor-QOL.

I'm using midi-qol and my macro for lucky looks like this:
game.dnd5e.rollItemMacro("Lucky (Halfling)")

The Minor-QOL looks like this and works:
MinorQOL.doRoll(event, "Lucky (Halfling)", {type: "feat", versatile: false});

@illandril illandril self-assigned this Aug 31, 2020
@illandril illandril added the bug Something isn't working label Aug 31, 2020
@illandril
Copy link
Owner

This module doesn't require Minor-QOL, and works with macros created when using no other modules as well as when using Midi QOL. The reason your macro isn't showing the counts is that it's missing the trailing semicolon.

I'm going to update the macro matching to allow for the missing semicolon (as well extra whitespace and replacing the double-quotes with single-quotes or back-ticks).

@illandril illandril changed the title Doesn't work if you aren't using hotbar items that aren't Minor-QOL Doesn't work if the macro's format isn't perfect Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants