Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enumeration type definition has become disconnected #2

Closed
justiceb opened this issue Feb 9, 2023 · 21 comments
Closed

enumeration type definition has become disconnected #2

justiceb opened this issue Feb 9, 2023 · 21 comments
Labels
bug Something isn't working

Comments

@justiceb
Copy link

justiceb commented Feb 9, 2023

image

I've tested this in LV 2021 SP1 32 and 64 bit.

I've seen this before, I think it's an annoying LabVIEW bug. I've fixed this in the past by renaming the type definion within the user event and then recompiling.

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

Same issue exists for the Close UE "reason" typedef

@negentropicdev
Copy link
Contributor

Perhaps a funky masscompile issue, let me check this out on a machine I didn't develop this on and see if it's reproducing for me.

@negentropicdev
Copy link
Contributor

Confirmed. Hooray for LabVIEW not breaking with examples that have the event but don't break until trying to use the data. I'll hit up the linker info and see what LV thinks it has and try and track down where it lost it.

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

Cool, Glad to hear it's not just my computer then. I've seen this issue before, I'd be curious to know how exactly you solve it to relink things properly. I'd definitely put this in the "LV bug" category

@negentropicdev
Copy link
Contributor

Definitely not the same category as issue 3 ;)

@negentropicdev negentropicdev added the bug Something isn't working label Feb 9, 2023
@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

haha, issue #3 is a silly inconsequential mistake. This one is a bit more workflow breaking.
Cool code, I'm gonna use it for something. We'll see if I'm allowed to open-source what I use it for!

@negentropicdev
Copy link
Contributor

Found it. I must have moved it at some point and LV failed to type prop... but not break the internal code using it,
image

@negentropicdev
Copy link
Contributor

You see the virtual user group presentation I did on it with G Systems?

@negentropicdev
Copy link
Contributor

https://www.youtube.com/live/vHBlU43eIow?feature=share&t=1475 if you haven't seen the Good Company video game production chain calculator

@negentropicdev
Copy link
Contributor

Definitely curious what you'll be doing with it!

@negentropicdev
Copy link
Contributor

Hmmmm. It's fine on the property VI itself, I think this might be the issue Darren presented about in his ludicrous fixes to LV bit.
image

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

That's how I found this.

I emailed Jim Kring asking if he had ever seen anyone try to create dynamic splitters through the use of recursively nested subpanels with splitters inside of them. He said that he had tried it once, and promptly crashed LabVIEW lmao. But as a consolation prize, he directed me to that Gcon video. Total coincidence that we keep running into each other.

I hadn't seen the video game yet. Will check that out.

I open-sourced the Blue Origin plots with permission, but I wanted to make a multi-plot wrapper VIP package for those which would allow a user to quickly create and rearrange multiple plots on a single window with subpanels. Ideally, whatever layout the user would want. And then save/load the entire layout.

This code checks alot of cool boxes:

  • Running shutdown/cleanup on a panel will wait for the panel to signal that it has shutdown. This improves certainty that code isn't left running in an orphaned state
  • There is a built in mechanism where you can init stuff on a panel before signaling back up to the framework that the panel has entered a running state. This let's you open the FP in a hidden state, register control references for dynamic events, and then signal that the panel is running to the framework
  • Built-in signalling for visibility of the panel. A must-have
  • OOP makes it easy to have different flavors of panels, but use the same framework

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

Darren's content is always the best content on the forums. Love that guy

@negentropicdev
Copy link
Contributor

Dear github, just because a commit message says close doesn't mean I want the ticket closed...

Building VIP and testing an install from that. Will be updated on VIPM shortly after and I'll close the ticket then.

@negentropicdev
Copy link
Contributor

0.2.0.24 should be available on VIPM now. Of course I forgot that I hadn't pushed after the last publish so version numbers were a little out of whack, let me know if you have any issues with it now.

I had to recreate the event in the Panel Events.ctl typedef to get it to link correctly everywhere. Actually I replaced it with a boolean event to keep the element and force type prop and then I re-replaced it with the Close Reason enum again.

@negentropicdev
Copy link
Contributor

If you haven't seen it, make sure you check out the BD template snippet that's in the palettes for more quickly creating panel VIs

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

I saw that! I always feel weirded out burying an event structure in a case structure though. (I'm looking at you JKI state machine)

@negentropicdev
Copy link
Contributor

Yeah... reviewed a task today with Spencer on a library I was updating and on opening the BD the first thing that came out of his mouth was "why".

At least mine is meant purely for linear progression and doesn't bounce between events and "do things". It's an entire event loop in the case structure not an event in a case of a case structure, mine is stickier ;)

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

yeah, your top level case stucture could be replaced by a stacked sequence structure. it's just a linear stack. Easy to understand, makes the code more horizontally compact. I get it and don't mind it.

you do you :)

@justiceb
Copy link
Author

justiceb commented Feb 9, 2023

Issue still exists on latest VIPM package. womp

@justiceb
Copy link
Author

This is confirmed resolved in the latest build. Woot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants