Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acked sequence number wrong(?) after wrap around #629

Open
eerimoq opened this issue Feb 25, 2024 · 1 comment
Open

Acked sequence number wrong(?) after wrap around #629

eerimoq opened this issue Feb 25, 2024 · 1 comment

Comments

@eerimoq
Copy link

eerimoq commented Feb 25, 2024

Hi!

My RTMP client uses the acknowledged sequence number in the Acknowledgement control message to keep track of how much data that is in flight. It works well when streaming to Twitch and Youtube, but when streaming to this server it does not. The acked sequence number wraps at i32-max or u32-max in those services, and the next acked sequence number is the rest (modulus). In this server it wraps at 0xf0000000, and the next acked sequence number is always 0. So seems impossibly to kow exactly how much data is acked.

https://github.com/illuspas/Node-Media-Server/blob/master/src/node_rtmp_session.js#L498-L506

I can't find anything about this in the RTMP specification unfortunately.

Looks like GStreamer expects it to wrap at u32-max. https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpconnection.c?ref_type=heads#L973

@eerimoq
Copy link
Author

eerimoq commented Mar 26, 2024

Any comments on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant