Skip to content

Commit 1fbf220

Browse files
committed
Revert WBT MT disabling from dotnet#116747.
1 parent 2ba4606 commit 1fbf220

File tree

3 files changed

+34
-36
lines changed

3 files changed

+34
-36
lines changed

eng/pipelines/common/templates/browser-wasm-build-tests.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ jobs:
4141
jobParameters:
4242
dependsOn:
4343
- ${{ if eq(platform, 'browser_wasm') }}:
44-
# - build_browser_wasm_linux_Release_MultiThreaded_BuildOnly
44+
- build_browser_wasm_linux_Release_MultiThreaded_BuildOnly
4545
- build_browser_wasm_linux_Release_SingleThreaded_BuildOnly
4646
- ${{ if eq(platform, 'browser_wasm_win') }}:
47-
# - build_browser_wasm_windows_Release_MultiThreaded_BuildOnly
47+
- build_browser_wasm_windows_Release_MultiThreaded_BuildOnly
4848
- build_browser_wasm_windows_Release_SingleThreaded_BuildOnly
4949
isExtraPlatforms: ${{ parameters.isExtraPlatformsBuild }}
5050
testGroup: innerloop
@@ -67,22 +67,22 @@ jobs:
6767
TargetFolder: '$(Build.SourcesDirectory)/artifacts'
6868
CleanTargetFolder: false
6969

70-
# # Download for multi-threaded
71-
# - task: DownloadBuildArtifacts@0
72-
# displayName: Download built nugets for multi-threaded runtime
73-
# inputs:
74-
# buildType: current
75-
# artifactName: BuildArtifacts_browser_wasm_$(_hostedOs)_Release_MultiThreaded_BuildOnly
76-
# downloadType: single
77-
# downloadPath: '$(Build.SourcesDirectory)/artifacts'
70+
# Download for multi-threaded
71+
- task: DownloadBuildArtifacts@0
72+
displayName: Download built nugets for multi-threaded runtime
73+
inputs:
74+
buildType: current
75+
artifactName: BuildArtifacts_browser_wasm_$(_hostedOs)_Release_MultiThreaded_BuildOnly
76+
downloadType: single
77+
downloadPath: '$(Build.SourcesDirectory)/artifacts'
7878

79-
# - task: CopyFiles@2
80-
# displayName: Copy multithreading runtime pack
81-
# inputs:
82-
# SourceFolder: '$(Build.SourcesDirectory)/artifacts/BuildArtifacts_browser_wasm_$(_hostedOs)_Release_MultiThreaded_BuildOnly'
83-
# Contents: packages/$(_BuildConfig)/Shipping/Microsoft.NETCore.App.Runtime.Mono.multithread.*
84-
# TargetFolder: '$(Build.SourcesDirectory)/artifacts'
85-
# CleanTargetFolder: false
79+
- task: CopyFiles@2
80+
displayName: Copy multithreading runtime pack
81+
inputs:
82+
SourceFolder: '$(Build.SourcesDirectory)/artifacts/BuildArtifacts_browser_wasm_$(_hostedOs)_Release_MultiThreaded_BuildOnly'
83+
Contents: packages/$(_BuildConfig)/Shipping/Microsoft.NETCore.App.Runtime.Mono.multithread.*
84+
TargetFolder: '$(Build.SourcesDirectory)/artifacts'
85+
CleanTargetFolder: false
8686

8787
# Download WBT
8888
- task: DownloadBuildArtifacts@0
@@ -108,7 +108,7 @@ jobs:
108108
/p:Configuration=$(_BuildConfig)
109109
/p:TestUsingWorkloads=true
110110
/p:InstallWorkloadForTesting=true
111-
/p:WasmSkipMissingRuntimePackBuild=false
111+
/p:WasmSkipMissingRuntimePackBuild=true
112112
/p:PreparePackagesForWorkloadInstall=false
113113
/p:WorkloadsTestPreviousVersions=$(workloadsTestPreviousVersionsVar)
114114
timeoutInMinutes: 180

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -233,17 +233,16 @@ jobs:
233233
publishArtifactsForWorkload: true
234234
publishWBT: true
235235

236-
# disabled: https://github.com/dotnet/runtime/issues/116492
237-
# - template: /eng/pipelines/common/templates/wasm-build-only.yml
238-
# parameters:
239-
# platforms:
240-
# - browser_wasm
241-
# - browser_wasm_win
242-
# nameSuffix: MultiThreaded
243-
# extraBuildArgs: /p:WasmEnableThreads=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
244-
# condition: ne(variables['wasmMultiThreadedBuildOnlyNeededOnDefaultPipeline'], true)
245-
# publishArtifactsForWorkload: true
246-
# publishWBT: false
236+
- template: /eng/pipelines/common/templates/wasm-build-only.yml
237+
parameters:
238+
platforms:
239+
- browser_wasm
240+
- browser_wasm_win
241+
nameSuffix: MultiThreaded
242+
extraBuildArgs: /p:WasmEnableThreads=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
243+
condition: ne(variables['wasmMultiThreadedBuildOnlyNeededOnDefaultPipeline'], true)
244+
publishArtifactsForWorkload: true
245+
publishWBT: false
247246

248247
# Browser Wasm.Build.Tests
249248
- template: /eng/pipelines/common/templates/browser-wasm-build-tests.yml

src/mono/wasm/Wasm.Build.Tests/Common/BuildEnvironment.cs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,12 @@ public BuildEnvironment()
104104
}
105105

106106
IsWorkloadWithMultiThreadingForDefaultFramework = IsMultiThreadingRuntimePackAvailableFor(BuildTestBase.DefaultTargetFramework);
107-
// MT is disabled on CI: https://github.com/dotnet/runtime/issues/116492
108-
// if (IsWorkload && EnvironmentVariables.IsRunningOnCI && !IsWorkloadWithMultiThreadingForDefaultFramework)
109-
// {
110-
// throw new Exception(
111-
// "Expected the multithreading runtime pack to be available when running on CI." +
112-
// $" {nameof(IsRunningOnCI)} is true but {nameof(IsWorkloadWithMultiThreadingForDefaultFramework)} is false.");
113-
// }
107+
if (IsWorkload && EnvironmentVariables.IsRunningOnCI && !IsWorkloadWithMultiThreadingForDefaultFramework)
108+
{
109+
throw new Exception(
110+
"Expected the multithreading runtime pack to be available when running on CI." +
111+
$" {nameof(IsRunningOnCI)} is true but {nameof(IsWorkloadWithMultiThreadingForDefaultFramework)} is false.");
112+
}
114113

115114
UseWebcil = EnvironmentVariables.UseWebcil;
116115

0 commit comments

Comments
 (0)