Add OfFloat.from methods in Point/Rectangle

This commit adds Rectangle.OfFloat.from and Point.OfFloat.from methods
and removes the Win32DPIUtils.FloatAwareGeometryFactory class to make
these methods OS-independent. It additionally adds clone methods in
Point class and sub-classes and Rectangle.OfFloat::clone.

Author: amartya4256

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/Point.java

@@ -43,7 +43,7 @@
  * @see <a href="http://www.eclipse.org/swt/">Sample code and further information</a>
  */
 
-public sealed class Point implements Serializable permits Point.OfFloat {
+public sealed class Point implements Serializable, Cloneable permits Point.OfFloat {
 
 	/**
 	 * the x coordinate of the point
@@ -118,6 +118,15 @@ public String toString () {
 	return "Point {" + x + ", " + y + "}"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
 }
 
+/**
+ * Creates and returns a shallow copy of this {@code Point}.
+ * @since 3.132
+ */
+@Override
+public Point clone() {
+	return new Point(x, y);
+}
+
 /**
  * Instances of this class represent {@link org.eclipse.swt.graphics.Point}
  * objects with the fields capable of storing more precise value in float.
@@ -158,6 +167,21 @@ public void setY(float y) {
 		this.y = Math.round(y);
 		this.residualY = y - this.y;
 	}
+
+	@Override
+	public Point.OfFloat clone() {
+		return new Point.OfFloat(getX(), getY());
+	}
+
+	/**
+	 * Creates a shallow copy of the provided point as a Point.OfFloat instance.
+	 */
+	public static Point.OfFloat from(Point point) {
+		if (point instanceof Point.OfFloat pointOfFloat) {
+			return pointOfFloat.clone();
+		}
+		return new Point.OfFloat(point.x, point.y);
+	}
 }
 
 /**
@@ -187,13 +211,22 @@ public WithMonitor(int x, int y, Monitor monitor) {
 		this.monitor = monitor;
 	}
 
+	private WithMonitor(float x, float y, Monitor monitor) {
+		super(x, y);
+		this.monitor = monitor;
+	}
+
 	/**
 	 * {@return the monitor with whose context the instance is created}
 	 */
 	public Monitor getMonitor() {
 		return monitor;
 	}
 
+	@Override
+	public Point.WithMonitor clone() {
+		return new WithMonitor(getX(), getY(), monitor);
+	}
 }
 
 }

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java

@@ -459,6 +459,21 @@ public void setHeight(float height) {
 		this.residualHeight = height - this.height;
 	}
 
+	@Override
+	public Rectangle.OfFloat clone() {
+		return new Rectangle.OfFloat(getX(), getY(), getWidth(), getHeight());
+	}
+
+	/**
+	 * Creates a shallow copy of the provided Rectangle as a Rectangle.OfFloat instance.
+	 */
+	public static Rectangle.OfFloat from(Rectangle rectangle) {
+		if (rectangle instanceof Rectangle.OfFloat rectangleOfFloat) {
+			return rectangleOfFloat.clone();
+		}
+		return new Rectangle.OfFloat(rectangle.x, rectangle.y, rectangle.width, rectangle.height);
+	}
+
 }
 
 /**

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/Win32DPIUtils.java

@@ -115,7 +115,7 @@ public static float pixelToPoint(Drawable drawable, float size, int zoom) {
 
 	public static Point pixelToPoint(Point point, int zoom) {
 		if (zoom == 100 || point == null) return point;
-		Point.OfFloat fPoint = FloatAwareGeometryFactory.createFrom(point);
+		Point.OfFloat fPoint = Point.OfFloat.from(point);
 		float scaleFactor = DPIUtil.getScalingFactor(zoom);
 		float scaledX = fPoint.getX() / scaleFactor;
 		float scaledY = fPoint.getY() / scaleFactor;
@@ -170,7 +170,7 @@ public static Rectangle scaleBounds (Rectangle rect, int targetZoom, int current
 	 */
 	private static Rectangle scaleBounds (Rectangle.OfFloat rect, int targetZoom, int currentZoom) {
 		if (rect == null || targetZoom == currentZoom) return rect;
-		Rectangle.OfFloat fRect = FloatAwareGeometryFactory.createFrom(rect);
+		Rectangle.OfFloat fRect = Rectangle.OfFloat.from(rect);
 		float scaleFactor = DPIUtil.getScalingFactor(targetZoom, currentZoom);
 		float scaledX = fRect.getX() * scaleFactor;
 		float scaledY = fRect.getY() * scaleFactor;
@@ -221,7 +221,7 @@ public static float pointToPixel(Drawable drawable, float size, int zoom) {
 
 	public static Point pointToPixel(Point point, int zoom) {
 		if (zoom == 100 || point == null) return point;
-		Point.OfFloat fPoint = FloatAwareGeometryFactory.createFrom(point);
+		Point.OfFloat fPoint = Point.OfFloat.from(point);
 		float scaleFactor = DPIUtil.getScalingFactor(zoom);
 		float scaledX = fPoint.getX() * scaleFactor;
 		float scaledY = fPoint.getY() * scaleFactor;
@@ -330,20 +330,4 @@ public ImageData getImageData(int zoom) {
 			return DPIUtil.scaleImageData(device, imageData, zoom, currentZoom);
 		}
 	}
-
-	private class FloatAwareGeometryFactory {
-		static Rectangle.OfFloat createFrom(Rectangle rectangle) {
-			if (rectangle instanceof Rectangle.OfFloat) {
-				return (Rectangle.OfFloat) rectangle;
-			}
-			return new Rectangle.OfFloat(rectangle.x, rectangle.y, rectangle.width, rectangle.height);
-		}
-
-		static Point.OfFloat createFrom(Point point) {
-			if (point instanceof Point.OfFloat) {
-				return (Point.OfFloat) point;
-			}
-			return new Point.OfFloat(point.x, point.y);
-		}
-	}
 }