-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private fields and interfaces make file inspection difficult #222
Comments
Yeah, the crate doesn't really expose an interface for editing existing TIFF files at the moment. You can use |
Given the way the library is structured with Decoder and Encoder, I get the idea that modifying existing file is out of scope, and that seems fine to me. My real issue is that even duplicating a file with paired Decoder/Encoder seems impossible given that the set of tags is un-knowable. Would it make sense to make fully pub (not just I can make some of these changes but would be ideal if I design it for future upstreamability |
Exposing the |
My use case is relatively simple:
I need to look for images (within the IFD of a given file) with a particular (Tag, Value) pair and remove them.
Zooming out, it would be nice if the API supported such a use case relatively directly (for example, streaming images from a
Decoder
toEncoder
, potentially with a filter).Still, implementing this by hand looks to be difficult to impossible, because:
Image
ispub(crate)
, meaning I cannot iterate a list of tags. Alternatively, a member function to provideDirectory
would be helpful.Am I approaching this wrongly? Thanks in advance for thoughts or advice.
The text was updated successfully, but these errors were encountered: