Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on stable channel #83

Closed
theotherphil opened this issue Jan 9, 2016 · 5 comments
Closed

Support building on stable channel #83

theotherphil opened this issue Jan 9, 2016 · 5 comments
Assignees

Comments

@theotherphil
Copy link
Contributor

Might be as easy as just sticking the [bench] tests behind a feature flag.

@bvssvni
Copy link
Contributor

bvssvni commented Jan 9, 2016

Use cfg_attr like this.

@softprops
Copy link

+1

@theotherphil theotherphil changed the title Support building on stable branch Support building on stable channel Jan 9, 2016
@theotherphil theotherphil self-assigned this Jan 10, 2016
@theotherphil
Copy link
Contributor Author

Thanks Sven. Doug, I'll sort this one out today.

@theotherphil
Copy link
Contributor Author

Slightly annoying:

nightly rustc requires:

let mut out = ImageBuffer::<ChannelMap<P, S>, Vec<S>>::new(width, height);

stable rustc requires:

let mut out = ImageBuffer::<ChannelMap<P, S>>::new(width, height);

rust-lang/rust#30123

Luckily it's easy to appease both:

let mut out: ImageBuffer<ChannelMap<P, S>, Vec<S>> = ImageBuffer::new(width, height);

@theotherphil
Copy link
Contributor Author

Can now build (but not test) on stable, and I've added stable and beta to the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants