Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better automatic detection of platform-specific jars #90

Open
imagejan opened this issue Sep 18, 2020 · 2 comments
Open

Better automatic detection of platform-specific jars #90

imagejan opened this issue Sep 18, 2020 · 2 comments

Comments

@imagejan
Copy link
Member

It would be desirable if the updater could better detect platform-specific files and only install those relevant for the current platform (while still allowing uploading for all platforms, of course).

As an example, here are the files shipped by the LUMoS update site, including platform-specific versions of several artifacts:

  • mkl-(linux|macosx|windows)*.jar
  • mkl-dnn-(linux|macosx|windows)*.jar
  • nd4j-native-*.jar
  • openblas-(linux|macosx|windows)*.jar

LUMoS_update

@hinerm
Copy link
Member

hinerm commented Sep 25, 2020

@imagejan this feature actually exists already but isn't really documented. After entering webdav credentials to upload, the side panel in Advanced mode becomes editable. This allows entering extra metadata about any file.

Under the platform section, you can enter one of the platforms known by the updater (linux32, linux64, macosx, tiger, win32, win64) and then upload the file to your update site. Then that file should only be managed by the updater when that platform is considered "active" (which is based on... a number of things?... including launchers detected).

image

At the least, we could add this to the wiki

@imagejan
Copy link
Member Author

imagejan commented Sep 26, 2020

Thanks for the clarification, @hinerm!

IIUC, that means that the maintainers of the LUMoS update site have to make that change manually so that users get just the files required for their platform, right? (/cc @tristan-mcrae-rochester)

I guess this issue becomes then: "Better automatic detection of platform-specific jars", as I think it would be useful if the updater can detect common patterns for platform-specific jars automatically, without requiring explicit information of the maintainer uploading the files to the update site.

@imagejan imagejan changed the title Better detection of platform-specific jars Better automatic detection of platform-specific jars Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants