Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Image Open error when running ImageJ commands #203

Closed
hinerm opened this issue Apr 21, 2023 · 3 comments
Closed

No Image Open error when running ImageJ commands #203

hinerm opened this issue Apr 21, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hinerm
Copy link
Member

hinerm commented Apr 21, 2023

  1. Open napari
  2. Open brick
  3. Run Gaussian Blur... command (highlighted in yellow)
  4. Get No Image error

image

I'm assuming this command needs to be run from the ImageJ GUI because it needs an ImageWindow? We probably don't want to show any Ij1 commands then right..?

@hinerm hinerm added the bug Something isn't working label Apr 21, 2023
@gselzer
Copy link
Collaborator

gselzer commented Apr 25, 2023

I'm assuming this command needs to be run from the ImageJ GUI because it needs an ImageWindow? We probably don't want to show any Ij1 commands then right..?

@hinerm so what we can do is use the LegacyImageMap to set the current ImagePlus to the current active layer on the fly, so that these things would work. I think I started doing this on the active-layer-to-active-ij-window branch with this commit. I never did finish that work, though...

@gselzer gselzer self-assigned this Apr 25, 2023
@gselzer gselzer modified the milestones: 1.0.0, 0.1.0, 0.2.0 Apr 25, 2023
@ctrueden
Copy link
Member

@gselzer What if the napari user opens, say, three different images into napari, i.e. three image layers? Then they try running a plugin such as Image Calculator, which allows to select which images you want to operate upon? We want to ensure that all three of these napari images are available as options in the ImageJ plugin's dialog box. We could always sync all image layers from Python to Java just prior to executing a command... but what about interactive GUI mode? Should GUI mode behave differently than headless mode? It would be strange for a bunch of ImageWindows to appear every time you run a command from the napari-imagej widget, wouldn't it?

@gselzer
Copy link
Collaborator

gselzer commented May 12, 2023

I'm closing this, as #207 has been merged.

@gselzer gselzer closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants