Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovering Commands that aren't visible #262

Closed
kephale opened this issue Jun 5, 2023 · 2 comments
Closed

Discovering Commands that aren't visible #262

kephale opened this issue Jun 5, 2023 · 2 comments

Comments

@kephale
Copy link
Contributor

kephale commented Jun 5, 2023

Hi Folks,

I cannot discover some Commands that are declared in SNT, like https://github.com/morphonets/SNT/blob/master/src/main/java/sc/fiji/snt/plugin/SkeletonizerCmd.java

I know we can use the imagej-ops thinning ops, but this is really about testing Commands from SNT. I would point out that this Command is declared with visible = false hence the topic title, but I suspect that might be a red herring.

Can someone help me understand why the SkeletonizerCmd won't show up in the napari-imagej search bar with this endpoint:
endpoint = "sc.fiji:fiji:2.13.0+org.morphonets:SNT:MANAGED"

Thank you!
Kyle

@gselzer
Copy link
Collaborator

gselzer commented Jun 5, 2023

Command is declared with visible = false hence the topic title, but I suspect that might be a red herring.

@kephale I think that's the opposite of a red herring 😆

In ModuleSearcher.search, we call ModuleSearcher.isGoodModule, and one of the conditions for a "good Module" is that it is visible. Furthermore the Plugin method suggests that when it is true, it shouldn't show up in the UI. So I think the behavior is correct here?

@kephale
Copy link
Contributor Author

kephale commented Jun 5, 2023

@gselzer good point. Maybe it would be better to revisit why those aren't visible in SNT!

@gselzer gselzer closed this as completed Jun 6, 2023
@gselzer gselzer closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants