Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does this still need to run tests in Node 14 and 16? And what about 20? #149

Open
peterbe opened this issue Sep 20, 2023 · 0 comments
Open

Does this still need to run tests in Node 14 and 16? And what about 20? #149

peterbe opened this issue Sep 20, 2023 · 0 comments

Comments

@peterbe
Copy link

peterbe commented Sep 20, 2023

Node 16 is end-of-life. I don't even know what Node 14 is at this point? :)

I wonder, can we change the versions matrix in .github/workflows/test.yml to test, Node 18 and Node 20 only. And to update the engines for node to '^16 || ^18 || ^20', which means it'll work in Node 16 (but not tested in automation).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbe