Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cookie version 0.18 #29

Closed
blueowlgreenfish opened this issue Oct 14, 2023 · 3 comments
Closed

Support for cookie version 0.18 #29

blueowlgreenfish opened this issue Oct 14, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@blueowlgreenfish
Copy link

https://github.com/SergioBenitez/cookie-rs/blob/master/CHANGELOG.md

@imbolc imbolc added the good first issue Good for newcomers label Oct 14, 2023
@wbcat
Copy link

wbcat commented Nov 26, 2023

I did it for axum main, which will become axum 0.7

It was just changing some lines in Cargo.toml

[dependencies]
axum-core = { git = "https://github.com/tokio-rs/axum.git", optional = true }
cookie = { version = "0.18", features = ["percent-encode"] }
http = "1"

[dev-dependencies]
hyper = "1.0.1"
once_cell = "1.18"

@imbolc
Copy link
Owner

imbolc commented Nov 26, 2023

@wbcat feel free to make a PR, though we should stick with the Axum release which is based on the old Hyper

@wbcat
Copy link

wbcat commented Nov 26, 2023

I will wait for axum 0.7 to be published and then will proceed with a PR if feasible.

This was referenced Nov 27, 2023
@imbolc imbolc closed this as completed in a5365ab Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants