Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock before removal (once nodes are fully unavailable). #895

Open
piascikj opened this issue Nov 29, 2017 · 0 comments
Open

Unlock before removal (once nodes are fully unavailable). #895

piascikj opened this issue Nov 29, 2017 · 0 comments
Labels

Comments

@piascikj
Copy link
Member

This could be achieved through doing prune inside the lock
and having a cleanup method which actually performs the
deletions on the snapshotters which support it.

opened via imdone.io from a code comment on 5bd902b5cf by Michael Crosby

TODO Unlock before removal (once nodes are fully unavailable). id:894


// TODO: Unlock before removal (once nodes are fully unavailable).
// This could be achieved through doing prune inside the lock
// and having a cleanup method which actually performs the
// deletions on the snapshotters which support it.
for _, node := range roots {
if err := s.pruneBranch(ctx, node); err != nil {
return 0, err
}

@piascikj piascikj added the TODO label Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant