-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable handleTouch doesn't work #220
Comments
amhofny
added a commit
to amhofny/drift
that referenced
this issue
Mar 19, 2019
- edit test case "accepts custom settings" to test for handleTouch and injectBaseStyles when they are set to false - edit code to check for key in options instead of normal ||
2 tasks
amhofny
added a commit
to amhofny/drift
that referenced
this issue
Mar 19, 2019
amhofny
added a commit
to amhofny/drift
that referenced
this issue
Apr 2, 2019
1- remove extra unnecessary comments 2- ensure that handleTouch and injectBaseStyles gets assigned a truthy value 3- remove dist/* from pull request
amhofny
added a commit
to amhofny/drift
that referenced
this issue
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Disabling handleTouch is not working, if you set to false, the default value true will always be used, and the same goes for injectBaseStyles.
To Reproduce
Just set handleTouch to false and check the result, a more appropriate way is to edit the test case "accepts custom settings", like below to include "handleTouch" and "injectBaseStyles", and then run tests:
Expected behaviour
handleTouch and injectBaseStyles to remain false after initialization with custom options, and touch is disabled on mobile.
Information:
The text was updated successfully, but these errors were encountered: