Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in IE 10 and below due to const #137

Closed
tedw opened this issue May 22, 2019 · 2 comments · Fixed by #138
Closed

Error in IE 10 and below due to const #137

tedw opened this issue May 22, 2019 · 2 comments · Fixed by #138

Comments

@tedw
Copy link

tedw commented May 22, 2019

Hi there,

I just started using Imgix and am a big fan so far. The only issue I’ve run into is that the script fails on IE 10 and below because of this one const (browser support):

const defaultConfigType = typeof defaultConfig[key];

const defaultConfigType = typeof defaultConfig[key];

Would you all mind changing that const to a var, or maybe providing a transpiled version of the script? I know hardly anyone uses IE 10 these days but this seemed like a pretty minor change and would allow those few holdouts to get images.

Thanks!

@sherwinski
Copy link
Contributor

Hi @tedw, glad to hear that! No problem at all, I'll go ahead and swap those out for you 👍

@tedw
Copy link
Author

tedw commented May 24, 2019

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants