Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views.bundle returns BundleView, but BundleView class is not public #351

Open
cmhulbert opened this issue Oct 17, 2023 · 3 comments
Open

Comments

@cmhulbert
Copy link

Views.bundle returns a BundleView but the class BundleView is not public, so effectively Views.bundle cannot be used. I believe BundleView should be public

@tpietzsch
Copy link
Member

...or Views.bundle should return RandomAccessible<RandomAccess<T>>?

@cmhulbert
Copy link
Author

Yeah, It could go either way. the only field in BundleView is protected, so I think it would effectively be the same? I'm not sure what the thinking is with other View types, like IntervalView, but it may be nice to create BundleView without View.bundle or to subclass them, for example, a BundleView that takes an RAI and is itself also an RAI

@tpietzsch
Copy link
Member

I'm not sure what the thinking is with other View types, like IntervalView,

There is not much thinking... :-)
Actually, I would eventually prefer to hide all these special View types and have the Views methods all return only basic RandomAccessible, RandomAccessibleInterval, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants