[Tech-Debt] Use luxon for user deletion calculation

[jrasm91]

user.service.ts#isReadyForDeletion uses Date millisecond parsing, but should use luxon, for a much cleaner implementation.

    // TODO use luxon for date calculation
    const msInDay = 86_400_000;
    const msDeleteWait = msInDay * 7;
    const msSinceDelete = Date.now() - (Date.parse(user.deletedAt.toString()) || 0);

    return msSinceDelete >= msDeleteWait;

[manasadepu]

Hey, first time contributor here. Can I take this issue?

[manasadepu]

`import { DateTime } from 'luxon';
const msDeleteWait = 7 * 24 * 60 * 60 * 1000;
const deletedAt = DateTime.fromJSDate(user.deletedAt || new Date(0));
const msSinceDelete = DateTime.now().diff(deletedAt).as('milliseconds');

return msSinceDelete >= msDeleteWait;`

[manasadepu]

This is my idea for the solution, would this be considered concise enough?

[jrasm91]

Feel free to open a pull request to discuss it

[danieldietzler]

Done in #6958