-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DSLR pictures for metadata tests #4
Comments
cc @etnoy |
Yes, if you have specific cameras with odd metadata, please add samples here and write tests. Make sure you publish your assets in the public domain |
I will write a fix for it in exiftools-vendored, where I'll also add tests with example images. Is it still necessary to add tests here? |
Why not? I'd like to have a wide variety of test assets in here so we can ensure problematic cases are handled well |
Specifically the timezone metadata that I'm interested in should be handled by exiftools-vendored afaik. But of course it could still be useful to check other things here. I can of course provide the images. Not sure if I would want to write tests for it |
Ideally I'd like a few samples from most major DSLR cameras. As a Nikon user I've uploaded some raw files from my cameras. Feel free to upload some a7 samples. |
I did some digging and I found an online repository of many raw images of different camera models. This repository is available under the creative commons license and can be found on https://rawsamples.ch/. I would suggest using this. |
That is a great repository, however the reason for having our own repo is that we use it in automatic testing. It appears that rawsamples is in the public domain, so if we find odd quirks we don't handle correctly I suggest copying in those specific cases into our repo. We can't just take in everything since git doesn't like lots of raw photos, we need to be smart in what we include. |
I'm making this issue to inform if DSLR pictures are desired to test if the metadata is correctly extracted. I'm interested in this, because currently the timezone information is not correctly extracted for my camera (Sony A7 first gen). Since I can set a timezone in the camera settings, I believe this information is stored somewhere in the metadata and it should be able to be extracted.
In discord the following was mentioned by user "etnoy" leading me to this repository:
The text was updated successfully, but these errors were encountered: