Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm does not work for n=1 #4

Open
LingxiaoShawn opened this issue Oct 3, 2024 · 2 comments
Open

Algorithm does not work for n=1 #4

LingxiaoShawn opened this issue Oct 3, 2024 · 2 comments

Comments

@LingxiaoShawn
Copy link

Hi author,

Thank you for the great work. The algorithm runs very fast!
However, I think the current algorithm does not consider the corner case with just single GPU (n=1), and in this case, the allocate function's while loop just run forever.

Is there a way to easily fix the problem?

Thank you!

@LingxiaoShawn
Copy link
Author

LingxiaoShawn commented Oct 3, 2024

I changed line the to

        if l <= n:
            break  # Can't allocate each sequence to a single machine

and it works, not sure whether this is correct.

@LingxiaoShawn
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant