Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Add support for emoji icons #10

Open
tbeu opened this issue Sep 24, 2015 · 11 comments
Open

Add support for emoji icons #10

tbeu opened this issue Sep 24, 2015 · 11 comments

Comments

@tbeu
Copy link

tbeu commented Sep 24, 2015

Search for "xml" in the search field. The only hit contains an emoji Icon in its description which is displayed as text.

@xogeny
Copy link

xogeny commented Sep 24, 2015

This is because the person who added the description for that library chose to include GitHub specific emoji markup in the description. I'm rendering exactly the description the library author included.

An argument could be made that it would be nice if the emoji images were embedded in the impact search results. I would accept a pull request for this. But I couldn't find an existing package that takes HTML with emoji markup and returns HTML with emoji images embedded and I don't want to implement that functionality right now.

@xogeny xogeny closed this as completed Sep 24, 2015
@tbeu
Copy link
Author

tbeu commented Sep 24, 2015

@xogeny
Copy link

xogeny commented Sep 24, 2015

Perhaps. I'll investigate.

@xogeny xogeny reopened this Sep 24, 2015
@xogeny
Copy link

xogeny commented Sep 28, 2015

No. The one you referenced converts unicode characters into the associated image.

The module required in this case must transform a string that uses markup into HTML. This one handles that.

@xogeny
Copy link

xogeny commented Sep 28, 2015

BTW, this is a very nice reference for the various markup patterns:

http://www.emoji-cheat-sheet.com/

@xogeny
Copy link

xogeny commented Sep 28, 2015

It should be noted that emojify seems to be the standard. But it also includes a very large CSS file. An alternative approach, used here, is to include a bunch of static images. This means less downloading up front.

I don't really want to host all those static images within the GitHub page. I think it is "neater" to just have the CSS fine. So I'm more inclined to go with emojify. But this is pretty low on my list of priorities.

@tbeu
Copy link
Author

tbeu commented Sep 28, 2015

BTW, this is a very nice reference for the various markup patterns:
http://www.emoji-cheat-sheet.com/

Guess what I use all the time? 😏

@dietmarw
Copy link
Member

@tbeu Until this is resolved you might consider removing the emoji from your description.

@tbeu
Copy link
Author

tbeu commented Oct 28, 2015

But they are really nice eye-catchers in the GitHub description. 🎃

@tbeu
Copy link
Author

tbeu commented Jan 6, 2016

HNY! 🎆

@tbeu
Copy link
Author

tbeu commented Jan 20, 2017

🆕 January ⛄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants