-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement ES256
verification
#101
Merged
Merged
+112
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…lt_did_method`
ES256
verificationES256
verification
1 task
6 tasks
daniel-mader
reviewed
Aug 5, 2024
aabbbdc
to
64bc428
Compare
daniel-mader
approved these changes
Aug 7, 2024
berkes
pushed a commit
to educredentials/ssi-agent
that referenced
this pull request
Aug 14, 2024
* refactor: undo unnecessary changes * docs: list all config values * refactor: rename config file * refactor: remove example files from docker image * refactor: merge config files * refactor: update .dockerignore to include all Dockerfiles and .env files * WIP: migrate from config macro to config function * refactor: configs for `log_format` and `event_store` * refactor: remove unused macros calls * refactor: migrate `url` config * refactor: `secret_manager` config * refactor: `credential_configurations` config * refactor: rename `DidMethodOptions`, add config for `signing_algorithms_supported` * refactor: determine default DID method * refactor: remove comments, load env variables * WIP: refactor `event_publishers` config * refactor: remove `metadata` * refactor: remove `config!` macro * refactor: rename `config_2` to `config` * chore: change example logo, disable `event_publisher`, respect `default_did_method` * chore: resolve clippy issues * refactor: remove `set_metadata_configuration` * refactor: remove `TEST_METADATA` * WIP * test: fix tests * ci: update docker-compose * fix: replace `localhost` with container name * refactor: clean up code * chore: fix unused import * chore: remove unused deployment scripts * refactor: read `connection_string` inside postgres module * refactor: rename env prefix to `UNICORE` * feat: init `IsuanceService` * refacotr: remove unused code * feat: add `from_jsonwebtoken_algorithm_to_jwsalgorithm` helper function * chore: remove unused code * feat: add `generate_stronghold` option * feat: implement `ES256` verification * chore: update logo URI's in example config file * chore: remove temp stronghold file * chore: remove `example-config.yaml` file * chore: remove unused `identity_iota` dependencies * refactor: remove unused 'services' * refactor: use `from_jsonwebtoken_algorithm_to_jwsalgorithm` * fix: reset config source to `agent_application/config.yaml` * feat: update config files * chore: update docker-compose file * chore: update docker-compose file * chore: remove commented code * fix: don't use `example.config.yaml` by default * fix: use `get_preferred_signing_algorithm` * fix: add tests --------- Co-authored-by: Daniel Mader <daniel.mader@impierce.com>
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Please write a summary of your changes and why you made them.
Blocked by
IssuanceServices
for signing and verifying #98Links to any relevant issues
Closes #102
How the change has been tested
To test against UniMe:
UniCore
agent_application/example.config.yaml
into a file namedagent_application/config.yaml
with:
UNICORE__URL
environment variable first, e.g.:http://192.168.1.127:3033
):agent_application/docker
docker compose up --build
UNICORE__URL
variable is set):UniMe
ES256
signature algorithm identity-wallet#236cargo tauri dev
The transfer should be successful.
Extra validation
by searching through the log messages from UniCore for this:
You can verify that the Proof of Possession JWT that UniMe sent to UniCore that its header should look something like this:
Also when searching for
you can find the actual returned credential and that its header also contains
"alg": "ES256"
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.