Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move .dockerignore to the root, because it won't be respected otherwise #84

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Norlock
Copy link
Contributor

@Norlock Norlock commented Jun 20, 2024

Description of change

See reason in first comment: https://stackoverflow.com/questions/53945934/docker-compose-and-dockerignore

How the change has been tested

Docker builds with few bytes instead of 18gb

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@Norlock Norlock requested a review from nanderstabel June 20, 2024 12:37
@nanderstabel nanderstabel added the Chore Tedious, typically non-functional change label Jun 20, 2024
@Norlock Norlock merged commit 55fb839 into dev Jun 20, 2024
1 check passed
@Norlock Norlock deleted the fix/mv-dockerignore branch June 20, 2024 13:11
berkes added a commit to educredentials/ssi-agent that referenced this pull request Jun 26, 2024
* upstream/dev: (23 commits)
  feat: add `issuance-config.yml` file, deprecate `/v0/configurations/credential_configurations` endpoint (impierce#91)
  chore: revert api version to `v0` (impierce#88)
  chore: improve Dockerfile and docker functionality  (impierce#89)
  feat: add support for multiple credential formats (impierce#85)
  fix: move dockerignore because it won't be respected otherwise (impierce#84)
  feat: add `/v1/configurations/credential_configurations` endpoint (impierce#83)
  feat: add Metadata `config.yml` file (impierce#82)
  chore: add tracing to `agent_event_publisher_http` (impierce#80)
  chore: use `domain-linkage` (no `-fetch`) feature in `identity_credential` (impierce#79)
  feat: create and serve `Domain Linkage Credential` (impierce#77)
  docs: list available events (impierce#78)
  feat: produce and serve `did:web` DID documents (impierce#31)
  feat: add support for `PresentationDefinition` by value (impierce#72)
  feat: use polling strategy for JIT credentials (impierce#71)
  ci: switch from manual triggers to pushes to `dev` (impierce#76)
  ci: use dedicated `arm64` runner (impierce#74)
  feat: add `offer_id` to all `OfferEvent` events (impierce#69)
  feat: enable `CorsLayer` (permissive) based on env variable (impierce#66)
  fix: add image `tags` in `merge` job (impierce#63)
  fix: add `state` to `AuthorizationResponseVerified` events (impierce#60)
  ...
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change released on @alpha released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants