Create a WP user account in backend after a manual donation

[Gilles2705]

Hi

When registration/login is enabled on the GiveWP installation, and a donor already has an account on the installation, he can only make a donation by logging in first. If the email address of the account is provided and the donor is NOT logged in, an error is shown.
Ideally, people, also registered donors, should be able to make a new donation without having to log in, just as is possible with email access / users without registered accounts.
This issue was written in 2021 but not fixed (https://feedback.givewp.com/bug-reports/p/donors-with-account-can-only-donate-again-while-logging-in)

Then, I wrote a little snippet which creates a WP user account and associates it to the Give WP donor when a new donation has been made thru the GiveWP form thru front-end.

Everything works fine in front-end, but when creating a new donation in BACK-END via the MANUAL DONATION addon, the WP USER ACCOUNT IS NOT CREATED :(
Is there any problem using the "give_insert_payment" hook or "wp_create_user()" in back-end ?

Thanks for helping !

Gil

Here's the little snippet :

add_action('give_insert_payment', 'create_donor_user_and_associate_donation', 10, 2);

function create_donor_user_and_associate_donation($payment_id, $payment_data) {
    $email = give_get_payment_user_email($payment_id);
    $user = get_user_by('email', $email);

    // If the user doesn't exist, we create it
    if (!$user) {
        $random_password = wp_generate_password(12, false);
        $user_id = wp_create_user($email, $random_password, $email);

        // Define the user role as "give_donor"
        $user = new WP_User($user_id);
        $user->set_role('give_donor');

        // Get the donor name et firstname from payment data
        $first_name = $payment_data['user_info']['first_name'];
        $last_name = $payment_data['user_info']['last_name'];

        // Update the name and firstname user
        wp_update_user([
            'ID' => $user_id,
            'first_name' => $first_name,
            'last_name' => $last_name
        ]);

        // Associate the WordPress user to the GiveWP donor
        $donor = new Give_Donor($user_id);
        $donor->create([
            'email'       => $email,
            'first_name'  => $first_name,
            'last_name'   => $last_name,
            'user_id'     => $user_id,
        ]);
    } else {
        $user_id = $user->ID;
        // Check if WP user is already associated to a GiveWP donor
        $donor = new Give_Donor($user_id);
        if (!$donor->id) {
            // Associate the WordPress user to the GiveWP donor
            $donor->create([
                'email'       => $email,
                'first_name'  => $payment_data['user_info']['first_name'],
                'last_name'   => $payment_data['user_info']['last_name'],
                'user_id'     => $user_id,
            ]);
        }
    }

    // Associate the user to the donation
    give_update_payment_meta($payment_id, '_give_payment_user_id', $user_id);
}