Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation API endpoint should accept end date without start date #7594

Open
1 task
pulsovi opened this issue Oct 29, 2024 · 1 comment
Open
1 task

Donation API endpoint should accept end date without start date #7594

pulsovi opened this issue Oct 29, 2024 · 1 comment
Labels
Stale type: bug Existing functionality is broken

Comments

@pulsovi
Copy link
Contributor

pulsovi commented Oct 29, 2024

User Story

As a web integrator, I want to request Give API for oldest donations by using "end" request param so that returns the "end parameter invalid" error.

Details

When requesting wp-json/give-api/v2/admin/donations with end parameter but without start parameter, the request is rejected because "end parameter invalid".

Expected Behavior

When start is missing, end should not be tested to be after start.

Steps to Reproduce

  1. Request wp-json/give-api/v2/admin/donations?end=2023-12-31

Acceptance Criteria

  • Requesting wp-json/give-api/v2/admin/donations?end=2100-12-31 (very far away date) should return the same result as requesting without end parameter.
@pulsovi pulsovi added the type: bug Existing functionality is broken label Oct 29, 2024
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 additional days. Note, if this Issue is reporting a bug, please reach out to our support at https://givewp.com/support. If this is a feature request, please see our feedback board at feedback.givewp.com — that’s the best place to make feature requests, unless you’re providing a PR.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale type: bug Existing functionality is broken
Projects
None yet
Development

No branches or pull requests

1 participant