add Pulseq MATLAB calcAdcSeg as calc_adc_segments #194
felixlandmeyer
started this conversation in
Show and tell
Replies: 2 comments
-
Hi @felixlandmeyer, the GitLab link you provide requires a login (maybe repo is private?). In any case, if you create a pull request, we can review the implementation. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'm sorry. It should be public now. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I have created a Python implementation of
calcAdcSeg
on https://iffgit.fz-juelich.de/f.landmeyer/pypulseq/-/tree/add_calc_adc_segments.The code is a one-to-one translation of the Matlab code.
As far as I know, such an implementation is not yet published in pypulseq, so I can create a pull-request if desired.
I have tested the output of
calc_adc_segments
against the output ofcalcAdcSeg
with the output of the attached Matlab code and it is identical for all parameters tested. The output of the Matlab code is saved intest/expected_output
and read and tested bytest_calc_adc_segments
.Beta Was this translation helpful? Give feedback.
All reactions