Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRE Walkthrough notebook seems to have multiple bugs, with v1.4.0 at least #118

Closed
curtcorum opened this issue May 10, 2023 · 2 comments
Closed
Assignees

Comments

@curtcorum
Copy link

Describe the bug
GRE Walkthrough notebook seems to have multiple bugs, with v1.4.0 at least

To Reproduce
gre_walkthrough.ipynb on colab

Expected behavior
Halts on:

from pypulseq.make_trap_pulse import make_trapezoid

when above fixed halts next on:

rf, gz, gzr = make_sinc_pulse(flip_angle=alpha * math.pi / 180, duration=4e-3, slice_thickness=slice_thickness, apodization=0.5, time_bw_product=4, system=sys)

did not go farther...

Screenshots
pypulseq_make_trap_pulse_230510

pypulseq_make_sinc_pulse_230510

Desktop (please complete the following information):
gre_walkthrough.ipynb on colab

  • OS: see colab
  • OS Version: see colab
  • pypulseq version: 1.4.0

Additional context
Have not tried locally, some other examples seem to run ok on colab.

@btasdelen
Copy link
Collaborator

Thanks for catching this. It looks like this example is based on PyPulseq 1.3.0. If you have a working version, feel free to submit a PR. Otherwise, I can have a crack at it when I have the time.

@btasdelen
Copy link
Collaborator

Solved in #121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants