Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import with latest version of numpy not possible #122

Closed
schote opened this issue Jun 1, 2023 · 1 comment
Closed

Import with latest version of numpy not possible #122

schote opened this issue Jun 1, 2023 · 1 comment
Assignees

Comments

@schote
Copy link

schote commented Jun 1, 2023

Hi,

I installed pypulseq in a new conda environment, numpy 1.24 was automatically installed as a dependency.
When importing pypulseq numpy throws an error because np.float is not supported anymore.
Since numpy version 1.20.0 this is deprecated and it is recommended to use float. Since 1.24.0 an error is issued instead of a warning.

To Reproduce
Install pypulseq in a fresh environment:
pip install pypulseq
Import pypulseq
import pypulseq as pp
Error is raised on the import statement, import is not possible.

Version:
pypulseq version: 1.4.0

Workaround
After installing pypulseq, I reinstalled numpy with version 1.23 to avoid the error on import.
pip install numpy==1.23.0

@btasdelen
Copy link
Collaborator

Hi @schote, thanks for reporting this.

This problem is resolved in #115. The version of the PyPI may not include the fix. Since PyPulseq v1.4.0 is in bug fix phase, I would recommend pulling the dev branch directly and using it, rather than installing through pip or conda, until those are updated.

Closing the issue since it is already solved. Feel free to reopen if you want to discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants