You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I wanted to quickly turn off a spoiler by manually setting its area to 0. However, this did not have an effect on the sequence.
I believe the issue is that in block.py the method get_block() calculates the area and flat_area parameters of the trapezoid itself instead of getting them from the event. Maybe somewhere the area and flat_area can be checked for consistency but I don't know where would be the right place to do so. Any help is appreciated. Kind regards, Helge.
The correct way is to use grad_ro_spr.amplitude = 0.
Besides currently not being covered by the code (though perhaps we may be able to change this once changing the events to actual classes), changing area can be tricky to implement robustly. For example, should changing area allow changes to the duration of the gradient? E.g. increasing the area of a gradient with max_grad amplitude.
Describe the bug
I wanted to quickly turn off a spoiler by manually setting its area to 0. However, this did not have an effect on the sequence.
I believe the issue is that in
block.py
the methodget_block()
calculates thearea
andflat_area
parameters of the trapezoid itself instead of getting them from the event. Maybe somewhere the area and flat_area can be checked for consistency but I don't know where would be the right place to do so. Any help is appreciated. Kind regards, Helge.To Reproduce
Set the gradient area or flat_area to 0 and run the sequence again.
The text was updated successfully, but these errors were encountered: