Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore gradient_waveforms to fix calculte_kspace #109

Closed
wants to merge 2 commits into from
Closed

Restore gradient_waveforms to fix calculte_kspace #109

wants to merge 2 commits into from

Conversation

fzimmermann89
Copy link
Contributor

This should fix #107.

@fzimmermann89 fzimmermann89 requested a review from yupbank October 5, 2023 16:42
@fzimmermann89 fzimmermann89 force-pushed the dev branch 2 times, most recently from e35f883 to 4410ce0 Compare October 5, 2023 17:03
@fzimmermann89
Restore gradient_waveforms
58232ef 
This should fix imr-framework#107.
Also change description of calculate_kspacePP.
@btasdelen btasdelen mentioned this pull request Oct 18, 2023
Closed
@btasdelen
Copy link
Collaborator

calculate_kspace is reimplemented as calculate_kspacePP is deprecated.

@btasdelen btasdelen closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yupbank yupbank Awaiting requested review from yupbank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Sequence' object has no attribute 'gradient_waveforms' in Sequence.calculate_kspace
3 participants
@fzimmermann89 @btasdelen @yupbank