Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor App Architecture #30

Open
kwe92 opened this issue Oct 21, 2024 · 5 comments
Open

Refactor App Architecture #30

kwe92 opened this issue Oct 21, 2024 · 5 comments

Comments

@kwe92
Copy link

kwe92 commented Oct 21, 2024

Would you be willing to let me refactor your apps architecture?

I would:

  • reduce the size of widgets (some are 1000 lines long)

  • remove state from views (turn all views stateless) and place presentation state in view models (using Provider package)

I can open a draft PR with some ideas I have and you can let me know if you like them.

@imrofayel
Copy link
Owner

@kwe92 Sure, it would be great, I know my code sucks. DM me on X, if you wanna discuss these changes.

@kwe92
Copy link
Author

kwe92 commented Oct 23, 2024

@imrofayel was the app meant to be ran in the browser on any device?

@imrofayel
Copy link
Owner

@kwe92 it's a desktop app primarily for Windows.

@amrgetment
Copy link

It is a great app, refactoring could be step-by-step
Like:

  • Adding code formatting like lefthook, so on push, it will fail if the code is not formatted
  • features folders and clean architecture
    application(blocs) - data(services/providers) - domain(repositories) - presentation(pages/ui)
    data > get data, domain > prepare the data, application > handle data logic in states relevant to UI > presentation
    and so on

@imrofayel
Copy link
Owner

@amrgetment Thank you for these suggestions. I wanna refactor this app since long but kinda busy in studies and job. But I'm willing to support any contribution. If you wanna collaborate on it, let me know. 🕊️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants