Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError causing Sidebar Expansion to Break #35

Open
d-marmalade opened this issue Jun 27, 2022 · 1 comment
Open

Uncaught TypeError causing Sidebar Expansion to Break #35

d-marmalade opened this issue Jun 27, 2022 · 1 comment

Comments

@d-marmalade
Copy link

I have a project using docsify, and it seems that the latest release of this plugin is breaking the sidebar expansion functionality.

Problem

When I run the site locally, sidebar expansion does not happen on click, and I encounter the following error in the console:

Uncaught TypeError: Cannot read properties of undefined (reading 'path')
  at k (docsify-pagination.min.js:1:4164)
  at i (docsify-pagination.min.js:1:6048)
  at o (docsify@4:1:107814)
  at o (docsify@4:1:107836)
  at o (docsify@4:1:107836)
  at docsify@4:1:107802
  at docsify-sidebar-collapse.min.js:1:4572
  at o (docsify@4:1:107782)
  at o (docsify@4:1:107836)
  at t.callHook (docsify@4:1:107852)

Workaround

Pinning docsify-pagination to v2.6.x (https://cdn.jsdeliver.net/npm/docsify-pagination@2.6/dist/docsify-pagination.min.js) fixes the issue.

Project State

This project is using:

  • docsify@4
  • docsify@4/lib/plugins/search.js
  • docsify-pagination
  • docsify-tabs@1
  • docsify-copy-code@2
  • docsify-sidebar-collapse
  • docsify/lib/plugins/zoom-image.min.js
  • prismjs@1
@imyelo
Copy link
Owner

imyelo commented Jun 28, 2022

Thanks for the feedback. There might be some optional chain protection missing. I just released 2.10.1, but I'm unsure if it's been fixed since I couldn't reproduce the issue. Could you help to confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants