Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference predicate is failing linter checks #404

Closed
TomHennen opened this issue Nov 6, 2024 · 2 comments
Closed

Reference predicate is failing linter checks #404

TomHennen opened this issue Nov 6, 2024 · 2 comments

Comments

@TomHennen
Copy link
Contributor

This is showing up in other PRs. Example.

Ideally the linter would tell us this before merging PRs that introduce these issues, but I guess it's not (or we just missed it).

@mdeicas do you think you'd be able to fix these linter errors?

@mdeicas
Copy link
Contributor

mdeicas commented Nov 12, 2024

This was actually fixed in 044ba49. I also suspect that it did not run in #375 because, by default, workflows on PRs from first time contributors (which I was) require approval -- see
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories.

@TomHennen
Copy link
Contributor Author

Ah, that makes sense about why it wasn't run (though it seems like ideally the maintainers would have been prompted to run it).

Oh, I see, and even though the fix was 'commited' a while ago, the PR with that fix wasn't submitted until last week. Great.

I suppose we can close this then (unless there's any further tweaking to do with getting the linter to run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants