Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded dependency to lux #93

Open
georgringer opened this issue Aug 29, 2021 · 3 comments
Open

Hardcoded dependency to lux #93

georgringer opened this issue Aug 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@georgringer
Copy link
Contributor

The NewsletterController got a hardcoded dependency to lux with

$visitorRepository = ObjectUtility::getObjectManager()->get(VisitorRepository::class);
@einpraegsam
Copy link
Collaborator

Yes I know. Any problems with this? Or: How can I reproduce an error with this? Or is it just a code cleanup proposal?

@einpraegsam einpraegsam added the enhancement New feature or request label Aug 30, 2021
@georgringer
Copy link
Contributor Author

I don't know yet as I currently don't really need the backend modules but I will try to check

@georgringer
Copy link
Contributor Author

I don't know when the ajax route for receiverDetailAjax is called but maybe only if lux is installed? however still a bad code small but fully understandable if you close the issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@einpraegsam @georgringer