Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run entire stack with docker compose #8

Open
alkoclick opened this issue Jun 13, 2020 · 1 comment
Open

Run entire stack with docker compose #8

alkoclick opened this issue Jun 13, 2020 · 1 comment

Comments

@alkoclick
Copy link

Hey there :)

I noticed the project uses a few docker scripts to launch various parts of the stack. According to the Joel test item #2 it's great if you can have a running app in a single step and I think a docker compose file can help deliver that.

I could help out delivering this. Is that something you'd be interested in, or is there a conscious decision against it?

Stay awesome 🔥

@inad9300
Copy link
Owner

Hey! Thanks for passing by and for offering your help! 🙂

Indeed, I use Docker for setting up the PostgreSQL database locally, which can be a bit tricky to install in different systems. npm streamlines things quite well for both client and server, with strong guarantees of working on every major platform, so I didn't see much of a reason to invest time on introducing Docker.

In fact, for production, there is a single build step for server and client, contained in the package.json of the root directory. The production database does require manual installation, as I haven't figured out a way to make use of the existing Docker setup with a free hosting/database provider.

During development, it is actually nice to run two separate commands and see immediately the logs from server and client in two different terminals. Nevertheless, more than two commands are required to get fully up and running at the moment, and based on your feedback I'm motivated to simplify this further!

All in all, I'm not necessarily against using Docker more, but at the moment I see no clear advantage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants