Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncorrect detecting rule missing space after "," #296

Closed
platinumthinker opened this issue Nov 18, 2015 · 2 comments
Closed

Uncorrect detecting rule missing space after "," #296

platinumthinker opened this issue Nov 18, 2015 · 2 comments
Labels
bug elvis_core

Comments

@platinumthinker
Copy link

Retry in code:

re:run(Name, "^.{1,20}$", [unicode]);

But work in this case:

RegExp = "^.{1,20}$",
re:run(Name, RegExp, [unicode]);
@jfacorro jfacorro added the bug label Nov 18, 2015
@jfacorro
Copy link
Contributor

@harenson I think you verified this after closing #319 and it is now working correctly?

@harenson
Copy link
Member

@jfacorro Yeah, there is an open PR for this test at inaka/elvis_core#22

This was fixed in inaka/elvis_core#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug elvis_core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@harenson @jfacorro @platinumthinker