Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach data to resources[1]$data #4

Closed
peterdesmet opened this issue Aug 19, 2022 · 4 comments
Closed

Attach data to resources[1]$data #4

peterdesmet opened this issue Aug 19, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@peterdesmet
Copy link
Member

Quick note to self: for higher compatibility with frictionless-r, it would be better to store the dataframes in package$resources[x]$data, rather than package$data. I know we just moved it to data, but the suggestion here would mean that write_package() would work out of the box. Food for thought.

@peterdesmet peterdesmet added the enhancement New feature or request label Aug 19, 2022
@damianooldoni
Copy link
Member

As far as I understood @jimcasaer and his team are using camtraptor intensively during this period and in the following two months. To avoid undesirable breaks, it's better to schedule the change on main branch together with him.

@peterdesmet peterdesmet transferred this issue from inbo/camtraptor Mar 6, 2024
@damianooldoni
Copy link
Member

I was thinking about this recently. As we "split" the reading functionality from camtraptor so that a camtrap DP can be used by any other analysis R package, we could do the following:

  1. camtrapdp reads the camtrap DP as proposed by @peterdesmet here above.
  2. camtraptor's reading function will adapt the format to package$data to maintain its internal data structure, if wished. We could move from this format later in camtraptor.

@damianooldoni damianooldoni removed the enhancement New feature or request label Mar 12, 2024
@damianooldoni damianooldoni added this to the code sprint (v1) milestone Mar 12, 2024
@damianooldoni damianooldoni removed this from the code sprint (v1) milestone Mar 20, 2024
@peterdesmet peterdesmet added the enhancement New feature or request label Mar 22, 2024
@peterdesmet
Copy link
Member Author

This is a nice to have. There is only a need to implement this once we create a write_camtrapdp().

@peterdesmet
Copy link
Member Author

To be considered for #74, closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants