Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the get_*() functions used as features in map_dep() #173

Closed
damianooldoni opened this issue Sep 14, 2022 · 1 comment
Closed

Rename the get_*() functions used as features in map_dep() #173

damianooldoni opened this issue Sep 14, 2022 · 1 comment

Comments

@damianooldoni
Copy link
Member

damianooldoni commented Sep 14, 2022

As shown in #171, six get_*() functions are possible "values" of feature argument in map_dep(), while five other get_* functions are not. This is far from ideal. We would expect the same behavior for all get_* functions.

Proposal of @peterdesmet which I agree with: rename the get_*() functions used as feature values in map_dep() to summarize_*():

summarize_n_species
summarize_n_obs
summarize_n_individuals
summarize_rai
summarize_effort

Deprecation of the correspondent get_* functions is still possible of course.

To be discussed with @jimcasaer tomorrow

@damianooldoni
Copy link
Member Author

This issue has been indirectly tackled during the camtraptor July 2023 coding sprint. See all new issues made by @peterdesmet starting with "Rename" or "Combine".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant